Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More helpful message regarding caller failure #30

Closed
stdedos opened this issue Feb 1, 2022 · 8 comments
Closed

More helpful message regarding caller failure #30

stdedos opened this issue Feb 1, 2022 · 8 comments

Comments

@stdedos
Copy link

stdedos commented Feb 1, 2022

I was wondering if you'd like to improve on the warning message given from the git-credential-keepassxc, when callers don't match.

I'd like to know who called me, so I can add (maybe?) them to the list.

@Frederick888
Copy link
Owner

Sure thing. I can change it to something like

/path/to/program (uid=1, gid=1) is not allowed to call git-credential-keepassxc

If it's not too complicated, I can even print out the command that adds the caller I guess. Hope I can have some time to tackle this this weekend. There are also a few dependency upgrades that need to be taken care of.

@stdedos
Copy link
Author

stdedos commented Feb 2, 2022

Sounds awesome to me!

Add the aforementioned (basic) details in the next to replace the N/A string (if the N/A string "has a meaning" keep it; add the newline regardless).

It'd be a cute addition to add the necessary command to add the caller too.

Looking forward in using this feature; I am now "back" at the minimal version.
I also like the notifications, but caller is mandatory then; I don't want to build it myself 😓

If you happen to have a debian directory, I have a pet project that can build this "automatically" in Docker.
Unless you have your own thing.

@stdedos
Copy link
Author

stdedos commented Feb 2, 2022

PS: Are you "planning" on opening discussions?

I have more "generic" questions; but I don't want to open necessarily open an issue (and/or then have a "very nicely-cut issue topic")

@Frederick888
Copy link
Owner

discussions

Enabled.

@stdedos
Copy link
Author

stdedos commented Feb 14, 2022

Thanks for merging the feature :-D

I hate to be the annoying one; but could you build a release? 😕
I am not familiar with / I don't use the Rust toolchain, and I don't have it downloaded to try and build from sources.

@Frederick888
Copy link
Owner

You can download from GHA for now.

@stdedos
Copy link
Author

stdedos commented Feb 14, 2022

Oh yeah - awesome :-D

@stdedos
Copy link
Author

stdedos commented Feb 14, 2022

In Ubuntu "it seems necessary" to also add:

Feb 14 12:31:10.865 INFO Dump is disabled
Feb 14 12:31:10.865 INFO Reading configuration from /home/u/.config/git-credential-keepassxc
Feb 14 12:31:10.865 INFO PID: 284122
Feb 14 12:31:11.037 INFO PPID: 284121
Feb 14 12:31:11.038 INFO Parent process path: /usr/bin/dash
Feb 14 12:31:11.038 INFO Canonical parent process path: /usr/bin/dash
Feb 14 12:31:11.046 INFO Run `git-credential-keepassxc caller add --uid 1000 --gid 1000 /usr/bin/dash` to add current caller to allowed caller list
Feb 14 12:31:11.046 ERRO /usr/bin/dash (uid=1000, gid=1000) is not allowed to call git-credential-keepassxc, Caused by: N/A

ofc, that could very well avoided by changing user shells (?), but for ages it's not the case (https://askubuntu.com/a/976487/645458, https://wiki.ubuntu.com/DashAsBinSh)

I can make a README.md PR if you'd agree with my analysis; or wherever you (want to) keep your FAQs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants