Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to disable features at runtime #37

Closed
imsodin opened this issue Mar 1, 2022 · 3 comments
Closed

Add config option to disable features at runtime #37

imsodin opened this issue Mar 1, 2022 · 3 comments

Comments

@imsodin
Copy link

imsodin commented Mar 1, 2022

Would be nice to be able to configure the compile time features. I.e. if added at compile time, still be able to e.g. call git-credential-keepassxc caller disable or whatever the syntax is, to disable said feature. Or to prevent the X-Y problem: What I want to do is disable the strict caller feature.

Thanks for creating and sharing this nice tool!

@Frederick888
Copy link
Owner

The point of strict-caller is exactly that it cannot be disabled at
runtime. Otherwise users could add a few callers and a database, disable
strict-caller, then clear out all callers and would still be able to
use the program, in which case it'd be somewhat-strict-caller,
wouldn't it? :P

So this is a non-goal. And tbh I don't understand why you need this.

@imsodin
Copy link
Author

imsodin commented Mar 1, 2022

I don't "need" it, it would just be convenient like to not need to compile and still use yubikey/notification features without having to whitelist callers. Another option that would suit my use-case would be to allow wildcards in the callers. I totally get if that's a non-goal for you, just wanted to bring it up - thanks for having taken the time to respond and keep up the good work!

@Frederick888
Copy link
Owner

cargo install --locked --features notification,yubikey git-credential-keepassxc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants