Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/feature: versioning tag support on github #50

Closed
liudger opened this issue Jan 17, 2020 · 6 comments
Closed

bug/feature: versioning tag support on github #50

liudger opened this issue Jan 17, 2020 · 6 comments

Comments

@liudger
Copy link
Contributor

liudger commented Jan 17, 2020

Make the firmware support semantic versioning.
https://semver.org
This makes updating saver. Now I am scared to update while developing ;)

@fredlcore
Copy link
Owner

I agree that this totally makes sense, but the amount of commits which would each require a patch-level increase of the version number would have to be done somewhat automagically. If I were to upload binary versions which I would have to compile first before uploading, this would not be too difficult because I could use preprocessor directives.
If you come up with a (shell) script that would change the patch level automatically when I do a git push, then this could be a solution. Otherwise I know I'll be too lazy to think about this everytime I make a push...

@liudger
Copy link
Contributor Author

liudger commented Jan 17, 2020

Could GitHub actions not do this for you?

@fredlcore
Copy link
Owner

I don't know. I work with VS Code, if you point me to a resource which explains how (and what) needs to be done, I can try to implement it. The limited time for this project does not allow me to do all the research myself for functions that are not essential (to me ;) ).

@liudger
Copy link
Contributor Author

liudger commented Jan 17, 2020

I have the same thing. Just want to do the essential. The first custom component just worked fine for me and also for Holger (another homey) to some point. Than it broke with the next version. Than I just wanted to do a bit more proper version. Before I know I was writing native integration that needs proper versioning :(

Maybe with a make file. I use it to upload a version to pypi.org
found something in this article. Just scanned it quickly
https://learn.sparkfun.com/tutorials/efficient-arduino-programming-with-arduino-cli-and-visual-studio-code/all

But I am not sure what exactly you do want to script. Everytime you do a push you want to automatically update the version?
I am stacking pushes till I have a proper working version and than make a version with all the changes and fixes. Maybe you can have a dev branch and merge it once in a while and create a version. The dev branch if for the developers who want to test out some new stuff or new device and master with versions is for the users who are already satisfied ? So this would update less regular.

@fredlcore
Copy link
Owner

Yes, I would like to update the patch level version to increase by one each time I push. Often times I push the _defs.h when a new parameter is decoded by a user or if I fix a bug somewhere. I could go down the road of using a dev branch, but still the versioning would apply to that one as well. Haven't really worked with make files yet, so I guess that would be a good reason to do so. Will have a look at the link, thanks.

@fredlcore
Copy link
Owner

Thanks for the link again, I found a way to do so not every time I push, but every time I build but that's fine as well. Will be coming with the next push.

fredlcore pushed a commit that referenced this issue Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants