add franklin flavored markdown #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
reviewed
Jul 8, 2021
| r, str, _ = execute_block(sb, block) | ||
| plain_fence = "\n```\n" => "\n```" # issue #101: consecutive codefenced blocks need newline | ||
| if r !== nothing && !REPL.ends_with_semicolon(block) | ||
| for (mime, ext) in [(MIME("image/svg+xml"), ".svg"), (MIME("image/png"), ".png"), (MIME("image/jpeg"), ".jpeg")] |
There was a problem hiding this comment.
@jkrumbiegel is this fine for svg output or is it better to use something like JuliaDocs/Documenter.jl#1538? I only included text/html in my PR for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have just duplicated the original function here with some changes, as I don't know what a good entry point for the "flavor" would be. The flavor struct could hold some more options, for example which mime types to use, and in what order. For example I added svg here because that was missing.
The only other part is that html showables are inserted in
~~~fences.