Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused HCL and rules in Makefile #18

Closed
4 tasks
pdmthorsrud opened this issue May 27, 2020 · 3 comments
Closed
4 tasks

Remove unused HCL and rules in Makefile #18

pdmthorsrud opened this issue May 27, 2020 · 3 comments
Assignees
@pdmthorsrud
Labels
good first issue Good for newcomers invalid This doesn't seem right

Comments

@pdmthorsrud
Copy link
Collaborator

pdmthorsrud commented May 27, 2020 •
edited
Loading

From what I can gather these are no longer in use. Please correct me if I'm wrong.

  • Delete presto-connect.hcl file. Has been replaced by presto.hcl.
  • Deletebuild certificate-handler rule in Makefile
  • Delete presto rule in Makefile. Has been replaced by rule presto1.
  • Change name of presto1 rule in Makefile to presto, and change make presto1 to make presto in README.md

Could potentially leave presto-connect.hcl as an example of a setup with more than one presto. If so, refactor so that its function as an example is obvious.
@pdmthorsrud pdmthorsrud added enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right and removed enhancement New feature or request labels May 27, 2020
@zhenik
Copy link
Collaborator

zhenik commented May 28, 2020 •
edited
Loading

A bit more.

@zhenik zhenik mentioned this issue May 28, 2020
Closed
4 tasks
@pdmthorsrud pdmthorsrud self-assigned this May 29, 2020
@zhenik
Copy link
Collaborator

zhenik commented May 29, 2020

@m88614 , take a look that I add some commands in Makefile (root directory) here #22 . PR #22 could be potential blocker

@pdmthorsrud
Copy link
Collaborator Author

@m88614 , take a look that I add some commands in Makefile (root directory) here #22 . PR #22 could be potential blocker

Ah, thanks for the headsup.

@pdmthorsrud pdmthorsrud mentioned this issue Jun 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdmthorsrud pdmthorsrud

Labels
good first issue Good for newcomers invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhenik @pdmthorsrud