Implemented Typing and Dialing Instructions #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
carterjmoore
commented
Mar 4, 2022
carterjmoore
commented
- Added TypeInstruction, which makes the user type a random 5-letter word, read from a text file
- Added DialInstruction, which makes the user type a random 7-digit phone number (no need to type the hyphen)
- Extra time is added for both instructions, as they take longer than usual, but we may want to adjust this value
- There is currently an issue, as described in Teams, where the keyboard stays up if it is open when you force stop the program from Android Studio
Typing instruction works now, just need to figure out the best way to store a large list of strings and get a random one
Word list is stored in a JSON file, then read into an arraylist in memory when the game starts. We get a random word from this list whenever the instruction is triggered.
Also made it so you get extra time if the current instruction is dialing or typing
Fixed a bug where keyboard wasn't hiding after dial instruction ends. Tweaked time added for the two instructions.
Implemented picking a random word directly from file using RandomAccessFile
TypeInstruction now does readLine() twice, which guarantees it's at the start of a line, so no need to loop now
fredy20501
reviewed
Mar 11, 2022
app/src/main/java/ca/unb/mobiledev/reflexrevolution/activities/GameActivity.java
Show resolved
Hide resolved
app/src/main/java/ca/unb/mobiledev/reflexrevolution/instructions/Instruction.java
Outdated
Show resolved
Hide resolved
app/src/main/java/ca/unb/mobiledev/reflexrevolution/instructions/TypeInstruction.java
Outdated
Show resolved
Hide resolved
app/src/main/java/ca/unb/mobiledev/reflexrevolution/instructions/TypeInstruction.java
Outdated
Show resolved
Hide resolved
app/src/main/java/ca/unb/mobiledev/reflexrevolution/instructions/TypeInstruction.java
Outdated
Show resolved
Hide resolved
app/src/main/java/ca/unb/mobiledev/reflexrevolution/instructions/TypeInstruction.java
Outdated
Show resolved
Hide resolved
|
By the way, I tested with an emulator and the keyboard didn't stay up when I force stop the program. The app just closes normally. (also no issues with my real phone) It might be the demon in your emulator acting up again 🤔 |
|
Ah, I see... well at least it works on your end🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.