Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with WEBP images conversion with Travis CI #4

Open
peter279k opened this issue Apr 28, 2019 · 4 comments
Open

Problem with WEBP images conversion with Travis CI #4

peter279k opened this issue Apr 28, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@peter279k
Copy link
Member

peter279k commented Apr 28, 2019

As title, I've found these image formats have some concerned problems.

  • According to the official reference, the imagebmp provided by GD extension only supports on php-7.2+.

This package requires php-7.2 version at least and can solve this problem.

That's why I do this on this PR #3.

  • According to the previous failed Travis CI build log, it looks like the php environment in Travis CI doesn't support the webp image.

I think we have to use the customized Docker image inside Travis CI if we need to test the webp image conversion.

@peter279k peter279k self-assigned this Apr 29, 2019
@peter279k peter279k added the enhancement New feature or request label Apr 29, 2019
@jenstornell
Copy link
Collaborator

As we talked about somewhere else, PHP 7.1+ should be required.

I don't have a solution for the webp problem, but I think it's important to keep that format, as it may be the standard image format in the future.

@peter279k
Copy link
Member Author

@jenstornell, I've created the discussion about webp image support on Travis-CI community.

@peter279k
Copy link
Member Author

peter279k commented May 2, 2019

@jenstornell, after researching a lot about building PHP with imagewebp support in Travis CI environment, I just find the "hard-core" way to resolve this.

Here are the Travis CI build log and repository:

The Travis CI will use the phpenv to switch pre-installed PHP version for doing CI works.

To avoid this work, I use the sudo permission to install a PHP version in Travis CI environment.

@jenstornell
Copy link
Collaborator

I need to learn Travis CI to understand how it all works.

I can see that the last run did not get any errors, so that's a good thing. If this works without too much trouble, maybe we could use that until a better solution shows up?

@jenstornell jenstornell changed the title Problem with BMP and WEBP images conversion Problem with WEBP images conversion with Travis CI May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants