Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings -Wdeprecated-copy #19

Open
mathieugouin opened this issue May 3, 2020 · 1 comment
Open

fix warnings -Wdeprecated-copy #19

mathieugouin opened this issue May 3, 2020 · 1 comment

Comments

@mathieugouin
Copy link
Contributor

mathieugouin commented May 3, 2020

As discussed in #18

if someone has some time, and a good knowledge of over-riding
C+ operators and copy constructors, i am interested to get advice
on  most recent change on the development branch:
"fix warnings -Wdeprecated-copy"

that patch avoids the warning by avoiding the offending custom
copy constructor entirely, by requiring clients to create their
own object, and pass a pointer into the offending methods instead
- so now, the custom copy constructor is not used at all; but it
does something clever (convoluted), which a default copy would
not - that indicates a smell, either in the original code (maybe
the custom copy constructor was never needed), or in a new bug
being introduced now (maybe it is needed in some cases; but now
it's special handling wont happen) - i have not had the bandwidth
to dig into it deeper; but i suspect that there is a less
intrusive way to fix that compiler warning
@bill-auger
Copy link
Member

bill-auger commented May 3, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants