feat: use cash.min.js on the page instead of CDN #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is live in production BTW. Making the PR for review. |
|
@raisedadead, sorry I'm just seeing this now. Thanks for deploying such a quick fix 👍 |
|
Yep - I do not like it though. |
|
I know what you mean. I'd like to take another pass at this and just use vanilla JS. If I remember correctly, Cash is just hiding or showing some elements, and maybe fetching something, so it should be possible. |
|
Sounds like a plan. But no rush, I know you are pretty swamped already. |
|
Awesome, sounds good. I'll add it to the Trello board so we have a place to track progress on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CDN is potentially having some CORS errors. Using the script on the auth page instead for now.
/cc @scissorsneedfoodtoo @ojeytonwilliams