fix(challenges): adding negative integer to challenge to improve tests

[nathanhannig]

ISSUES CLOSED: #210

Description

Challenge: ES6 - Write Higher Order Arrow Functions

The challenge could be completed without filtering out negative numbers. This change adds a negative integer so solutions must filter out negative integers as well. This better aligns with the challenges description of the problem.

I have also changed the word fraction to decimal numbers, since the array does not hold fractions.

I have also removed the first test to check for var. This is a copy/paste mistake since the test is for the previous two challenges and not this challenge.

Pre-Submission Checklist

• Your pull request targets the dev branch.
• Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
• All new and existing tests pass the command npm test.
• Use npm run commit to generate a conventional commit message.
  Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
• The changes were done locally on your machine and NOT GitHub web interface.
  If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

• Tested changes locally.
• Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #210

[scissorsneedfoodtoo]

@nathanhannig, thank you for taking the time to fix this issue! I really like all the changes you've made.

I just found one problem where it's still possible pass the challenge without filtering out the negative integers. This is because the third test just checks the first three numbers in the squaredIntegers array that gets returned. We can make it more rebust by changing it to the following:

        {
          "text":
            "<code>squaredIntegers</code> should be <code>[16, 1764, 36]</code>",
          "testString":
            "assert.deepStrictEqual(squaredIntegers, [16, 1764, 36], '<code>squaredIntegers</code> should be <code>[16, 1764, 36]</code>');"
        },

Would you mind updating this PR? Also, if possible, please check it out locally on your end. I tested it on Learn, but it would be good to have confirmation that it works.

[nathanhannig]

sure, I was on vacation so I should have time soon to update

[scissorsneedfoodtoo]

@nathanhannig, no problem, just take your time!

[nathanhannig]

I added it and it worked, but I think the git commands didn't work properly

I performed the following:

• git add *
• git commit --amend
• git push --force (had some issue so followed the git warning instructions that required me to perform a a git push --set-upstream origin fix/es6-curriculum and git pull origin fix/es6-curriculum and it now shows 3 commits?)

Do I need to close the PR and redo it?

[scissorsneedfoodtoo]

@nathanhannig, thanks for making those changes! And it seems like you did everything right, but just when you merged there were some conflicts that had to be resolved. I went ahead and did that through the web editor and now everything looks good.

Thank you for all of your hard work here! Looking forward to your next contribution 👍

[nathanhannig]

thanks @scissorsneedfoodtoo. Glad someone knows what they are doing 👍

[scissorsneedfoodtoo]

No problem, @nathanhannig, that's very kind of you. But I'm also still learning! Just happened to have that problem before, so I was able to help out in this case.

[raisedadead]

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀