This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
Add videoUrl field #298
Merged
Add videoUrl field #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouncey
suggested changes
Sep 4, 2018
| @@ -488,6 +494,7 @@ | |||
| "releasedOn": "Feb 17, 2017", | |||
| "challengeType": 0, | |||
| "translations": {}, | |||
| c/Url": "", | |||
|
@beaucarnes You have some linting errors, also you will need to update the challengeSchema to allow the videoUrl property to be a string, Joi may allow you to check a vaild url also? If it takes more than a minute of looking up I wouldn't worry about it too much. |
Bouncey
suggested changes
Sep 20, 2018
schema/challengeSchema.js
Outdated
| @@ -29,6 +29,7 @@ const schema = Joi.object().keys({ | |||
| }) | |||
| ), | |||
| guideUrl: Joi.string().uri({ scheme: 'https' }), | |||
| videoUrl: Joi.string(), | |||
There was a problem hiding this comment.
To allow for empty strings, this will need to be
Joi.string().allow('')Add vidoeUrl to repsponsive web design challenges. update schema fix schema and capitalization
beaucarnes
force-pushed
the
add-video
branch
from
ab32a2a
to
570470d
Compare
raisedadead
approved these changes
Sep 25, 2018
|
Nice work. Thanks @beaucarnes |
raisedadead
pushed a commit
that referenced
this pull request
Sep 25, 2018
## [3.2.1](v3.2.0...v3.2.1) (2018-09-25) ### Bug Fixes * Add videoUrl field ([#298](#298)) ([ce3cc22](ce3cc22))
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add vidoeUrl to responsive web design challenges.