Skip to content
This repository has been archived by the owner on Oct 16, 2019. It is now read-only.

Example link in lesson text opens to FCC website in same tab #58

Closed
mstellaluna opened this issue May 18, 2018 · 5 comments
Closed

Example link in lesson text opens to FCC website in same tab #58

mstellaluna opened this issue May 18, 2018 · 5 comments

Comments

@mstellaluna
Copy link
Member

Challenge Name
https://learn.freecodecamp.org/responsive-web-design/basic-html-and-html5/nest-an-anchor-element-within-a-paragraph

Issue Description
In the lesson text opens to freecodecamp.org website in the same tab. My suggestion is to have it open to a new tab so the camper does not lose lesson they are on.

Browser Information
Browser Name, Version:
Firefox Quantum 60.0.1 (64-bit)
Chrome: Version 66.0.3359.117 (64-bit)
Operating System: Windows 10 Pro 64-bit
Mobile, Desktop, or Tablet: Dell Latitude Laptop (15")

image

@beaucarnes
Copy link
Member

Normally I agree that links should open in a different tab but in this case I don't think it should open to a new tab. This is an example of the type of link that does not open into a new tab. If it opened into a new tab, it would be using HTML that is different than the HTML that the lesson text says it is an example of.

@mstellaluna
Copy link
Member Author

@beaucarnes Agreed, although if a camper though decides to click on that link as it is an active link, it will bring them to the freecodecamp.org website in the same tab they are viewing the lesson.

@Bouncey
Copy link
Member

Bouncey commented Jun 15, 2018

We could change the example to use a _blank. Ideally, we don't want to take users away from their lesson. I don't think there will be many queries over the target attribute.

Notes to contributors, this should be fixed in the freecodecamp/curriculum repository, the code is not held in learn.

@beaucarnes
Copy link
Member

I agree with both of you now. I noticed that target="_blank" is introduced in the previous lesson so hopefully people will understand when it is used in this lesson.

@Bouncey
Copy link
Member

Bouncey commented Jun 15, 2018

Issue moved to freeCodeCamp/curriculum #18 via ZenHub

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants