New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: better syntax highlighting for descriptions and instructions #627
feat: better syntax highlighting for descriptions and instructions #627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything LGTM but the text is not selectable yet and the PR for it in the respective package hasn't been merged after staying open for over a year
Hey @Nirajn2311, Thanks for pointing that out. What do you think we should do? |
I went ahead and did the following:
To test this out you need to do the following: flutter_highlight:
git:
url: https://github.com/sembauke/highlight.dart
ref: master
path: ./flutter_highlight after this you can get and run. let me know what you think of it. cc: @Nirajn2311 |
This adds better highlighting in the learn component. The readability is now better for both instructions and description.
It uses the highlightingView plugin that is already used for some of the aspects in news / learn.
Now instead of only highlighting the syntax that is normally highlighted by Prisma. It now highlights everything. Instead of having a boring container, with a bad font.
We should also consider different themes for the highlighter. This one is now set to
atom-one-dark
Before:
After: