Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

ISSUE on the decimal point notation #672

Closed
paulTchaa8 opened this issue Oct 30, 2018 · 6 comments
Closed

ISSUE on the decimal point notation #672

paulTchaa8 opened this issue Oct 30, 2018 · 6 comments
Labels
valid bug - reproduced Bug has been successfully reproduced in latest build wontfix

Comments

@paulTchaa8
Copy link

paulTchaa8 commented Oct 30, 2018

Issue Description

Hi. In fact it's not really a huge issue, though i would like to ask that for some of us who are francophons as sample, we use the comma**(,)** instead of the decimal dot notation**(.)** , and obviously i know that when doing so, the checker will not accept. I could use a regex to change it. What do you think about that dears??

Your Code / Link to Your Pen

this is my react calculator

Screenshot

@tbushman
Copy link
Contributor

tbushman commented Nov 1, 2018

@paulTchaa8 A valid point, yes. :) Thank you.

@tbushman tbushman added the valid bug - reproduced Bug has been successfully reproduced in latest build label Nov 1, 2018
@thecodingaviator
Copy link
Contributor

@tbushman I'm going ahead with this issue, but I'm not sure how to do 2 alternate options in :

image

@tbushman
Copy link
Contributor

@thecodingaviator @paulTchaa8 Upon consideration, I think we shouldn't accommodate a comma. I don't think any digital calculators use the comma. Please correct me if I'm wrong.

@thecodingaviator
Copy link
Contributor

I'm not sure of any digital and most physical calculators that might be using the , . I guess we should keep it as wontfix?

@ojeytonwilliams
Copy link
Contributor

I did a quick search for calculatrice and found http://www.calculette.com/ http://www.la-calculatrice.com/calculatrice-en-ligne.html http://www.la-calculatrice.fr/ which do partially use commas. I say partially, because when you click on the comma it is displayed as a decimal point.

So, technically it is used, but even dedicated francophone calculators just use it as a proxy for .

@thecodingaviator
Copy link
Contributor

I feel it is best to leave it as is, the comma introduces unnecessary complexity. I'm locking the discussion to collaborators from now on.

@freeCodeCamp freeCodeCamp locked and limited conversation to collaborators Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
valid bug - reproduced Bug has been successfully reproduced in latest build wontfix
Projects
None yet
Development

No branches or pull requests

4 participants