Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better TypeScript support #38

Open
SharonGrossman opened this issue Feb 22, 2023 · 0 comments
Open

Better TypeScript support #38

SharonGrossman opened this issue Feb 22, 2023 · 0 comments

Comments

@SharonGrossman
Copy link

Hi, first of all thanks for the great package.
I would like to point that I've had some issues with the package when using TypeScript, as the data array is not actually typed - codes() returns a string[] when it's supposed to be something like CurrencyCode[], because it is in fact a closed set of values (currency codes).

It led me to write this sort of a fork to this package: https://github.com/osskit/currencies

But I would really want to keep using this package instead - just if we could better granular types for the codes, return values of the getters, etc.
I'm not sure what's the maintaining status of this package, so I'll wait for a response, and in the mean time use the above suggested package.
Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant