Skip to content

Commit

Permalink
Its never a good idea to double free the same
Browse files Browse the repository at this point in the history
address.

MFC after:	1 week (after the other commits ahead of this gets MFC'd)
  • Loading branch information
rrs authored and rrs committed Aug 16, 2012
1 parent 8a9e433 commit 7c7c85d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sys/netinet/in.c
Expand Up @@ -573,7 +573,7 @@ in_control(struct socket *so, u_long cmd, caddr_t data, struct ifnet *ifp,
}
TAILQ_REMOVE(&ifp->if_addrhead, &ia->ia_ifa, ifa_link);
IF_ADDR_WUNLOCK(ifp);
ifa_free(&ia->ia_ifa); /* if_addrhead */
/* ifa_free(&ia->ia_ifa); - Double free?? */ /* if_addrhead */

IN_IFADDR_WLOCK();
TAILQ_REMOVE(&V_in_ifaddrhead, ia, ia_link);
Expand Down

0 comments on commit 7c7c85d

Please sign in to comment.