intro.2: add syscall.h to synopsis & mention emfile vars #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine. Normally, we'd use 'brooks' instead of 'Brooks' for reported by since that's his FreeBSD username. I think this is fine, but wold also be happy with the more vague 'filesystem dependent value' if people object to enshrining these values here. |
|
I'd like to include something like "filesystem dependent value" and then the values can be presented as examples rather than suggesting an exhaustive list. A reader of this page isn't likely to know what |
concussious
added a commit
to concussious/freebsd-src
that referenced
this pull request
Apr 24, 2024
The too many links error is actually dependent on the underlying filesystem. MFC after: 1 week Reported by: brooks Reviewed by: emaste, imp Signed-off-by: concussious <concussious@runbox.com> Pull Request: freebsd#1192
concussious
added a commit
to concussious/freebsd-src
that referenced
this pull request
Apr 24, 2024
MFC after: 1 week Reported by: brooks Reviewed by: emaste, imp Signed-off-by: concussious <concussious@runbox.com> Pull Request: freebsd#1192
concussious
added a commit
to concussious/freebsd-src
that referenced
this pull request
Apr 24, 2024
The too many links error is actually dependent on the underlying filesystem. MFC after: 1 week Reported by: brooks Reviewed by: emaste, imp Signed-off-by: Alexander Ziaee <concussious@runbox.com> Pull Request: freebsd#1192
concussious
added a commit
to concussious/freebsd-src
that referenced
this pull request
Apr 24, 2024
MFC after: 1 week Reported by: brooks Reviewed by: emaste, imp Signed-off-by: Alexander Ziaee <concussious@runbox.com> Pull Request: freebsd#1192
brooksdavis
reviewed
Apr 24, 2024
lib/libsys/intro.2
Outdated
Comment on lines
519
to
520
| .Va UINT32_MAX No on Xr fusefs 4 , and | ||
| .Va INT_MAX No on Xr tmpfs 4 |
There was a problem hiding this comment.
Suggested change
| .Va UINT32_MAX No on Xr fusefs 4 , and | |
| .Va INT_MAX No on Xr tmpfs 4 | |
| .Va FUSE_LINK_MAX No on Xr fusefs 4 , and | |
| .Va TMPFS_LINK_MAX No on Xr tmpfs 4 |
This seems awfully specific for an intro manpage.
concussious
added a commit
to concussious/freebsd-src
that referenced
this pull request
Apr 24, 2024
The too many links error is actually dependent on the underlying filesystem. MFC after: 1 week Reported by: brooks Reviewed by: brooks, emaste, imp Co-authored-by: Brooks Davis <brooks@one-eyed-alien.net> Signed-off-by: Alexander Ziaee <concussious@runbox.com> Pull Request: freebsd#1192
concussious
added a commit
to concussious/freebsd-src
that referenced
this pull request
Apr 24, 2024
MFC after: 1 week Reported by: brooks Reviewed by: brooks, emaste, imp Signed-off-by: Alexander Ziaee <concussious@runbox.com> Pull Request: freebsd#1192
brooksdavis
reviewed
Apr 24, 2024
concussious
added a commit
to concussious/freebsd-src
that referenced
this pull request
Apr 24, 2024
MFC after: 1 week Reported by: brooks Reviewed by: brooks, emaste, imp Signed-off-by: Alexander Ziaee <concussious@runbox.com> Co-authored-by: Brooks Davis <brooks@one-eyed-alien.net> Pull Request: freebsd#1192
concussious
changed the title
concussious
added a commit
to concussious/freebsd-src
that referenced
this pull request
Apr 26, 2024
The too many links error is actually dependent on the underlying filesystem. MFC after: 1 week Reported by: brooks Reviewed by: brooks, emaste, imp Co-authored-by: Brooks Davis <brooks@one-eyed-alien.net> Signed-off-by: Alexander Ziaee <concussious@runbox.com> Pull Request: freebsd#1192
concussious
added a commit
to concussious/freebsd-src
that referenced
this pull request
Apr 26, 2024
MFC after: 1 week Reported by: brooks Reviewed by: brooks, emaste, imp Signed-off-by: Alexander Ziaee <concussious@runbox.com> Co-authored-by: Brooks Davis <brooks@one-eyed-alien.net> Pull Request: freebsd#1192
concussious
force-pushed
the
intro.2
branch
2 times, most recently
from
5d577ea
to
3d43afd
Compare
concussious
added a commit
to concussious/freebsd-src
that referenced
this pull request
Apr 29, 2024
MFC after: 1 week Co-authored-by: brooks Reviewed by: brooks, emaste, imp Pull Request: freebsd#1192
concussious
added a commit
to concussious/freebsd-src
that referenced
this pull request
Apr 29, 2024
MFC after: 1 week Co-authored-by: brooks Reviewed by: brooks, emaste, imp Pull Request: freebsd#1192
concussious
added a commit
to concussious/freebsd-src
that referenced
this pull request
Apr 29, 2024
MFC after: 1 week Co-authored-by: brooks Reviewed by: brooks, emaste, imp Pull Request: freebsd#1192
MFC after: 1 week Co-authored-by: brooks Reviewed by: brooks, emaste, imp Pull Request: freebsd#1192
Reviewed by: imp Pull Request: freebsd#1192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is currently incorrect until filesystems are moved to section 4.
Does this make the creation of the files section in previous pr redundant?
Is it correct for me here to use "reported by"?
Thanks!