Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages: add package for NTP #1193

Merged
merged 1 commit into from
May 4, 2024
Merged

Conversation

llfw
Copy link
Contributor

@llfw llfw commented Apr 23, 2024

No description provided.

@llfw
Copy link
Contributor Author

llfw commented Apr 23, 2024

cc @evadot, @bapt

@evadot
Copy link
Contributor

evadot commented Apr 23, 2024

LGTM, but please add an UPDATING entry so people will know that they need to pkg install FreeBSD-ntp after an upgrade.

@bsdimp
Copy link
Member

bsdimp commented Apr 23, 2024

LGTM, but please add an UPDATING entry so people will know that they need to pkg install FreeBSD-ntp after an upgrade.

Should we have a single updating entry for all these things? Or one per. Seems like a single one to catch-up to the changes so far makes sense with followup ones as they land.

@bsdimp bsdimp self-assigned this Apr 23, 2024
@evadot
Copy link
Contributor

evadot commented Apr 23, 2024

LGTM, but please add an UPDATING entry so people will know that they need to pkg install FreeBSD-ntp after an upgrade.

Should we have a single updating entry for all these things? Or one per. Seems like a single one to catch-up to the changes so far makes sense with followup ones as they land.

One UPDATING entry for all pkgbase changes is good a long as the changes are commited at the same time (more or less).

@llfw
Copy link
Contributor Author

llfw commented Apr 24, 2024

i'll add UPDATING with each PR in the future, since they might not get all committed at the same time (depending on review), they can be merged into one before commit if needed.

do you want me to make a PR with an UPDATING for the recent ones? (i think that's this one, cron, and lpr at least?)

@evadot
Copy link
Contributor

evadot commented Apr 24, 2024

i'll add UPDATING with each PR in the future, since they might not get all committed at the same time (depending on review), they can be merged into one before commit if needed.

do you want me to make a PR with an UPDATING for the recent ones? (i think that's this one, cron, and lpr at least?)

Yes please.

@llfw
Copy link
Contributor Author

llfw commented Apr 24, 2024

#1196

@llfw
Copy link
Contributor Author

llfw commented Apr 30, 2024

#1196 was merged and includes the UPDATING entry for ntp package, but this commit (which contains the actual ntp package) hasn't been merged. that might be my fault for not noting that explicitly, but this should probably be merged as well.

Reviewed by: imp, manu
Pull Request: freebsd#1193
@freebsd-git freebsd-git merged commit 2f9966f into freebsd:main May 4, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants