Address module reproducibility issues #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankm
force-pushed
the
dankm/module-path
branch
2 times, most recently
from
da5a0e1
to
c5333f4
Compare
|
are these the only modules that use this pattern, or are you using them as an example? |
These are the only ones that I caught doing it. Most are doing it in a similar way to what I changed these to. Some are "building" the firmware by extracting a uuencoded file and then loading that. I searched for more, and didn't find any in-tree. Most look like this file in main. |
Use .PATH & bare filename. This prevents the real source path from being included in the built object, which improves reproducibility. Signed-off-by: Dan McGregor <dan.mcgregor@usask.ca> Reviewed by: imp Pull Request: freebsd#1211
|
This builds, and produces what looks good. Should autoclose in a few minutes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use .PATH & bare filename. This prevents the real source path from being included in the built object, which improves reproducibility.