fix i386 msun cexp tests #401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding another volatile helped only tested on openbsd (with freebsds libm tho)
|
Also I just copied this change over from my editor into the GitHub thing. I can't promise that it will compile. |
|
This looks OK to me, and it appears to work on 13-CURRENT with clang 8. Though I wonder why the same trick isn't needed to for the |
uqs
pushed a commit
that referenced
this pull request
Jun 1, 2019
Ensure the expected result is stored first in a volatile variable with the desired type. This makes all the tests succeed. Slightly changed from the original pull request, but functionally the same. Obtained from: #401 Submitted by: Moritz Buhl <gh@moritzbuhl.de> PR: 191676 MFC after: 3 days git-svn-id: svn+ssh://svn.freebsd.org/base/head@348500 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
uqs
pushed a commit
that referenced
this pull request
Jun 1, 2019
Ensure the expected result is stored first in a volatile variable with the desired type. This makes all the tests succeed. Slightly changed from the original pull request, but functionally the same. Obtained from: #401 Submitted by: Moritz Buhl <gh@moritzbuhl.de> PR: 191676 MFC after: 3 days
|
Committed in d364650, with some minor changes. |
mat813
pushed a commit
to mat813/freebsd
that referenced
this pull request
Jun 2, 2019
…on i386. Ensure the expected result is stored first in a volatile variable with the desired type. This makes all the tests succeed. Slightly changed from the original pull request, but functionally the same. Obtained from: freebsd#401 Submitted by: Moritz Buhl <gh@moritzbuhl.de> PR: 191676 MFC after: 3 days git-svn-id: https://svn.freebsd.org/base/head@348500 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
uqs
pushed a commit
that referenced
this pull request
Jun 7, 2019
Partially revert r271349, which disabled the msun cexp test #4 on i386. Ensure the expected result is stored first in a volatile variable with the desired type. This makes all the tests succeed. Slightly changed from the original pull request, but functionally the same. Obtained from: #401 Submitted by: Moritz Buhl <gh@moritzbuhl.de> PR: 191676
uqs
pushed a commit
that referenced
this pull request
Jun 7, 2019
Partially revert r271349, which disabled the msun cexp test #4 on i386. Ensure the expected result is stored first in a volatile variable with the desired type. This makes all the tests succeed. Slightly changed from the original pull request, but functionally the same. Approved by: re (gjb) Obtained from: #401 Submitted by: Moritz Buhl <gh@moritzbuhl.de> PR: 191676
mat813
pushed a commit
to mat813/freebsd
that referenced
this pull request
Jun 10, 2019
Partially revert r271349, which disabled the msun cexp test freebsd#4 on i386. Ensure the expected result is stored first in a volatile variable with the desired type. This makes all the tests succeed. Slightly changed from the original pull request, but functionally the same. Approved by: re (gjb) Obtained from: freebsd#401 Submitted by: Moritz Buhl <gh@moritzbuhl.de> PR: 191676 git-svn-id: https://svn.freebsd.org/base/stable/11@348787 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
mat813
pushed a commit
to mat813/freebsd
that referenced
this pull request
Jun 10, 2019
Partially revert r271349, which disabled the msun cexp test freebsd#4 on i386. Ensure the expected result is stored first in a volatile variable with the desired type. This makes all the tests succeed. Slightly changed from the original pull request, but functionally the same. Obtained from: freebsd#401 Submitted by: Moritz Buhl <gh@moritzbuhl.de> PR: 191676 git-svn-id: https://svn.freebsd.org/base/stable/12@348784 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
brooksdavis
pushed a commit
to CTSRD-CHERI/cheribsd
that referenced
this pull request
Jun 13, 2019
Ensure the expected result is stored first in a volatile variable with the desired type. This makes all the tests succeed. Slightly changed from the original pull request, but functionally the same. Obtained from: freebsd/freebsd-src#401 Submitted by: Moritz Buhl <gh@moritzbuhl.de> PR: 191676 MFC after: 3 days
bdrewery
pushed a commit
to bdrewery/freebsd
that referenced
this pull request
Jun 17, 2019
…on i386. Ensure the expected result is stored first in a volatile variable with the desired type. This makes all the tests succeed. Slightly changed from the original pull request, but functionally the same. Obtained from: freebsd#401 Submitted by: Moritz Buhl <gh@moritzbuhl.de> PR: 191676 MFC after: 3 days git-svn-id: svn+ssh://svn.freebsd.org/base/head@348500 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
moritzbuhl
pushed a commit
to moritzbuhl/msun-regress
that referenced
this pull request
Oct 22, 2021
Ensure the expected result is stored first in a volatile variable with the desired type. This makes all the tests succeed. Slightly changed from the original pull request, but functionally the same. Obtained from: freebsd/freebsd-src#401 Submitted by: Moritz Buhl <gh@moritzbuhl.de> PR: 191676 MFC after: 3 days
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding another volatile helped
only tested on openbsd (with freebsds libm tho)