Update vm_map.c #419
Closed
Update vm_map.c #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fault_type be initialized here since fault_type will be changed if the entry is wired and the program decided to jump to RetryLookup*? That is if the entry is wired entry, fault_type will be changed. But if the program later decides to jump to RetryLockup*, then the original contents from fault_typea will be lost.
|
Nice find. I think you are right. |
markjdb
added a commit
to markjdb/freebsd-dev
that referenced
this pull request
Dec 6, 2019
Suppose that the map entry is wired, so that we later assign fault_type = entry->protection. Suppose further that we jump back to RetryLookup. Then fault_type will no longer contain the original fault protection mask, but instead that of the wired entry. Submitted by: Wuyang Chung <wuyang.chung1@gmail.com> Reviewed by: kib MFC after: 3 days Github PR: freebsd/freebsd-src#419 Differential Revision: https://reviews.freebsd.org/D22683
|
Committed in r355469, thank you. |
uqs
pushed a commit
that referenced
this pull request
Dec 7, 2019
Suppose that the map entry is wired, so that we later assign fault_type = entry->protection. Suppose further that we jump back to RetryLookup. Then fault_type will no longer contain the original fault protection mask, but instead that of the wired entry. Submitted by: Wuyang Chung <wuyang.chung1@gmail.com> Reviewed by: kib MFC after: 3 days Github PR: #419 Differential Revision: https://reviews.freebsd.org/D22683 git-svn-id: svn+ssh://svn.freebsd.org/base/head@355469 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
uqs
pushed a commit
that referenced
this pull request
Dec 7, 2019
Suppose that the map entry is wired, so that we later assign fault_type = entry->protection. Suppose further that we jump back to RetryLookup. Then fault_type will no longer contain the original fault protection mask, but instead that of the wired entry. Submitted by: Wuyang Chung <wuyang.chung1@gmail.com> Reviewed by: kib MFC after: 3 days Github PR: #419 Differential Revision: https://reviews.freebsd.org/D22683
mat813
pushed a commit
to mat813/freebsd
that referenced
this pull request
Dec 9, 2019
Suppose that the map entry is wired, so that we later assign fault_type = entry->protection. Suppose further that we jump back to RetryLookup. Then fault_type will no longer contain the original fault protection mask, but instead that of the wired entry. Submitted by: Wuyang Chung <wuyang.chung1@gmail.com> Reviewed by: kib MFC after: 3 days Github PR: freebsd#419 Differential Revision: https://reviews.freebsd.org/D22683 git-svn-id: https://svn.freebsd.org/base/head@355469 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
brooksdavis
pushed a commit
to CTSRD-CHERI/cheribsd
that referenced
this pull request
Dec 11, 2019
Suppose that the map entry is wired, so that we later assign fault_type = entry->protection. Suppose further that we jump back to RetryLookup. Then fault_type will no longer contain the original fault protection mask, but instead that of the wired entry. Submitted by: Wuyang Chung <wuyang.chung1@gmail.com> Reviewed by: kib MFC after: 3 days Github PR: freebsd/freebsd-src#419 Differential Revision: https://reviews.freebsd.org/D22683
bdrewery
pushed a commit
to bdrewery/freebsd
that referenced
this pull request
Dec 17, 2019
Suppose that the map entry is wired, so that we later assign fault_type = entry->protection. Suppose further that we jump back to RetryLookup. Then fault_type will no longer contain the original fault protection mask, but instead that of the wired entry. Submitted by: Wuyang Chung <wuyang.chung1@gmail.com> Reviewed by: kib MFC after: 3 days Github PR: freebsd#419 Differential Revision: https://reviews.freebsd.org/D22683 git-svn-id: svn+ssh://svn.freebsd.org/base/head@355469 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
hardenedbsd-services
pushed a commit
to HardenedBSD/hardenedBSD
that referenced
this pull request
Feb 10, 2023
* adjust gitignore Signed-off-by: SchrodingerZhu <i@zhuyi.fan> * also add prefix for rust objects Signed-off-by: SchrodingerZhu <i@zhuyi.fan> * export statistics api for rust Signed-off-by: SchrodingerZhu <i@zhuyi.fan> * conform clang-format-9 Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fault_type be initialized here since fault_type will be changed if the entry is wired and the program decided to jump to RetryLookup*? That is if the entry is wired entry, fault_type will be changed. But if the program later decides to jump to RetryLockup*, then the original contents from fault_typea will be lost.