1.4.0 breaks optimization to not cache local files

[bdrewery]

Repositories on file:// are just local repositories. There's nothing special about them. They include all packages and the repository files.

a3433e1 disabled the optimization to not cache the files. There's no reason to have the files on the system twice. It's a waste of time, I/O, bandwidth with NFS, and space on the local system.

The only difference between a file:// repo and the local cache directory is the name of the files. The repo meta files are still fetched and processed into the local /var/db/pkg database.

[bdrewery]

As noted on ports@, having PKG_CACHEDIR set to the repodir (which was a workaround for caching local repository files before 1.3) now can trash the repository with checksum symlinks that were added in 1.3. This has not been noticed in 1.3 as local repositories skipped the cachedir that this change has broken.

[bapt]

fixes in master and release 1.4, will be in 1.4.5