Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports with DISTVERSIONPREFIX have certain issues #4

Open
2 tasks
alexdupre opened this issue Dec 17, 2018 · 9 comments
Open
2 tasks

Ports with DISTVERSIONPREFIX have certain issues #4

alexdupre opened this issue Dec 17, 2018 · 9 comments

Comments

@alexdupre
Copy link
Member

alexdupre commented Dec 17, 2018

Ports with DISTVERSIONPREFIX have certain issues with Portscout detection:

  • A new version (with prefix is detected even if it's the same one (without prefix)

screenshot_20181217_164135

  • Other issues ...
@koobs
Copy link
Member

koobs commented Apr 19, 2020

Some issues are somewhat expected, as explained in FreeBSD Ports r405250 in a past update

...
Additionally it turns out, portscout currently only uses/stores a
normalized version ('ver') in its database, in its general design
attempt to be a generic version comparison tool

In particular, portscout does not reference or store PORTVERSION
or DISTVERSION{FULL}, so we have nothing 'canonical' to compare
the responses from Github (tags) against.

This change special-cases Github in the FindNewestFile subroutine, which
was obtained via Portroach [2] (OpenBSD's portscout fork).

Extending this, we also now only match version-esque looking strings
from the tag, in an attempt to normalise, because they come in many
forms, including {foo-}X.Y.Z{-bar}, foo_X_Y_Z, among others.

We may be able to tweak certain cases

@koobs koobs changed the title Ports defining DISTVERSIONPREFIX don't seem to be correctly supported Ports with DISTVERSIONPREFIX have certain issues Apr 19, 2020
@koobs
Copy link
Member

koobs commented Apr 19, 2020

@alexdupre @yurivict If you have noticed other examples where prefixes/suffixed/other version formats have caused different classes of issues, please add them here.

@yurivict
Copy link
Member

yurivict commented Apr 19, 2020

misc/dynomite: 0.6.21-rc2 vs. v0.6.21-rc2 - listed as having a new version.

@koobs
Copy link
Member

koobs commented Apr 19, 2020

misc/dynomite: 0.6.21-rc2 vs. v0.6.21-rc2 - listed as having a new version.

Yep that's covered in the first class (i edited the original issue summary with a checkbox)

If there are any other categories id be keen to know what they are

@yurivict
Copy link
Member

When it comes to DISTVERSIONPREFIX this is the only kind that I saw.

@danfe
Copy link

danfe commented Mar 31, 2022

Apparently it's still unfixed as of 2022, e.g. for several of my ports I see this:
screenshot №1

Possibly related bug is that skipv keyword is being ignored:
screenshot №2
The port has PORTSCOUT=skipv:2.1.0 specified.

@elgithubo
Copy link

It seems that this issue affects my port, too:

20221204_19h07m58s_grim
20221204_19h09m44s_grim
20221204_19h19m30s_grim

I see no possible simple workaround using the PORTSCOUT Makefile variable which does not disable update notifications at all.
So I guess one just needs to ignore portscout in such cases?

@danfe
Copy link

danfe commented Dec 13, 2022

I see no possible simple workaround using the PORTSCOUT variable

There's nothing to work around here. It's a bug in portscout which must be hunt down and fixed.

So I guess one just needs to ignore portscout in such cases?

I prefer to not, as I want to see if/when something would change in this regard.

@tatsuki-makino
Copy link

It seems that the following explanation meant that this behavior was meant.

  • Any regexes or limitations below apply to just the version, not the
    whole distfile name.

At least USE_GITHUB ports seem to have been stripped down here with something like blenderbim- other than numbers and dots.
It looks like we'll need to pick it up as follows and implement a new key to match it.
($prematchver, $postmatchver) = ($`, $');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants