Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modulize the app: Need AMD #9

Open
Toktik opened this issue Jul 22, 2013 · 3 comments
Open

Modulize the app: Need AMD #9

Toktik opened this issue Jul 22, 2013 · 3 comments
Labels

Comments

@Toktik
Copy link
Contributor

Toktik commented Jul 22, 2013

The problem

index.html and freecar.js getting fat.

The solution

Implement AMD loader :)

Is require.js suitable for all?

@grigy
Copy link
Contributor

grigy commented Jul 23, 2013

I vote for this. Let's do it. I don't have much experience with AMD, but I think the templates should be separated. And maybe the large classes in freecar.js.

@ghost ghost assigned Toktik Jul 23, 2013
@artash
Copy link
Contributor

artash commented Jul 25, 2013

I am not familiar with AMD, but I do vote for splitting stuff into separate loadable modules. Non critical, milestone 0.2?

@Toktik
Copy link
Contributor Author

Toktik commented Jul 25, 2013

I suggest doing this early, before code gets fat. It will be much painful later.
This will require some folder move, file renaming and etc for greater architecture. So we need to arrange this with all developers, since merging will need some effort in case of folder/file renaming (I'm new to git, maybe there is some way to achieve this easily?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants