Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider abstracting out quotes.json #107

Closed
spences10 opened this issue Nov 27, 2017 · 3 comments
Closed

Consider abstracting out quotes.json #107

spences10 opened this issue Nov 27, 2017 · 3 comments
Assignees

Comments

@spences10
Copy link
Collaborator

Maybe this could be pulled from an API

Maybe the quotes.json file could be made into an npm package?

Would be good for a first timer with reference to @amandeepmittal's stoic-api for reference?

@amandeepmittal
Copy link
Member

Maybe we can create a separate npm package if the context of stoic-api does not fit here for every retweet.

@spences10
Copy link
Collaborator Author

I'm on it right now, seeing if there's an npm package already out there

This would be a good first issue, if I can find a suitable npm package I'll update the ticket with the details

@amandeepmittal
Copy link
Member

Or if you merge quotes.json in stoic-api, be my guest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants