Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding development branch #122

Closed
spences10 opened this issue Mar 11, 2018 · 12 comments
Closed

Consider adding development branch #122

spences10 opened this issue Mar 11, 2018 · 12 comments
Assignees

Comments

@spences10
Copy link
Collaborator

spences10 commented Mar 11, 2018

Please consider adding a development branch and possibly a branch for adding patches to

Also please consider adding the following protection on branches master, development and patch so they are protected:

image

Thanks

@amandeepmittal
Copy link
Member

amandeepmittal commented Mar 12, 2018

I do not have access to these settings. @QuincyLarson might be able to help us in this matter?

@spences10
Copy link
Collaborator Author

Maybe I should also update the contribution guidelines RE, make a branch from development give it a naming convention like user/branch/feature-issueNumber

Is that why there are so many branches on this repo as well[29 branches]?

@amandeepmittal
Copy link
Member

Yes, that is the reason.

@QuincyLarson
Copy link
Contributor

@amandeepmittal I've granted you full admin privileges for this project (I hadn't realized you didn't have them).

Feel free to create any branches or configurations you see necessary. Let me know if I can do anything to help :)

@amandeepmittal
Copy link
Member

Thanks @QuincyLarson!
@spences10 will update the branch as per your instructions over the weekend.

@spences10
Copy link
Collaborator Author

Cool, just to expand on the patch branch, it's how I have been managing dependency updates, I merge them into there then if there are any failures (failed Travis build) then the dev/master branches are not affected

@spences10
Copy link
Collaborator Author

I'l like to help maintain this too if that's ok with you @QuincyLarson and @amandeepmittal 🙏

I've contributed quite a lot to this project and would be happy to help maintain it.

@amandeepmittal
Copy link
Member

Ofcourse @spences10. You are the biggest contributor to thos project. @QuincyLarson can we give him the rights and add him as a maintainer?

@QuincyLarson
Copy link
Contributor

@spences10 I've granted you admin access as well :)

@spences10
Copy link
Collaborator Author

Wheeeee! Thanks @QuincyLarson 🙏

@spences10
Copy link
Collaborator Author

This can be closed now, I have done all the admin

@amandeepmittal do you know any good CI tools for Heroku?

@amandeepmittal
Copy link
Member

Travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants