Skip to content
This repository has been archived by the owner on Oct 16, 2019. It is now read-only.

Pane re-sizing allows you to shrink but not expand #49

Closed
mstellaluna opened this issue May 18, 2018 · 3 comments
Closed

Pane re-sizing allows you to shrink but not expand #49

mstellaluna opened this issue May 18, 2018 · 3 comments
Labels
help wanted Open for everyone. You do not need permission to work on these. May need familiarity with codebase.

Comments

@mstellaluna
Copy link
Member

mstellaluna commented May 18, 2018

Challenge Name
https://learn.freecodecamp.org/responsive-web-design/basic-html-and-html5/say-hello-to-html-elements
Issue Description
There are several issues here (similar to the issue that already existed in Beta):

  1. When shrinking and expanding the lesson pane => the editor size does not expand to the new pane size when expanding the lesson pane. No issue on expanding the lesson pane, adjusts accordingly
    image

  2. Shirking the editor window is fine, expanding has several issues
    a) does not allow you to expand the editor window, this green highlighted bar shows up
    image
    b) to get the editor back, you need to re-size the lesson plan, then you can re-size the editor/preview pane
    image

  3. After attempting to expand the editor/preview pane which fails, if you move your cursor over the lesson pane ( no mouse button is clicked) the cusor changes to from arrow to expanding icon and it resizes the editor/preview pane and follows the mouse movement.

Browser Information
Browser Name, Version:
Firefox Quantum 60.0.1 (64-bit)
Chrome: Version 66.0.3359.117 (64-bit)
Operating System: Windows 10 Pro 64-bit
Mobile, Desktop, or Tablet: Dell Latitude Laptop (15")

@Bouncey Bouncey added the help wanted Open for everyone. You do not need permission to work on these. May need familiarity with codebase. label May 18, 2018
@beaucarnes
Copy link
Member

beaucarnes commented May 18, 2018

I'm not sure if this is the same issue or not but I'll just put it here since it is similar. When I start with a small window, select a new challenge, and then try to resize, then the editor pane stays small. The width of the editor pane seems to always stay the same width as it was when the challenge was initially selected.

Also, on small window sizes, the error messages in the bottom right are hard to see. See gif for demonstration.
fcc1

@scissorsneedfoodtoo
Copy link

@mstellaluna and @beaucarnes, I'm working on this now. Made some changes to both the editor and the output so that they expand and shrink horizontally when the browser window is resized. I'm currently working on a way to resize them vertically, and also resize horizontally/vertically when the panes resized, but the window size remains the same.

@Bouncey
Copy link
Member

Bouncey commented May 21, 2018

Closed via #82

@Bouncey Bouncey closed this as completed May 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Open for everyone. You do not need permission to work on these. May need familiarity with codebase.
Projects
None yet
Development

No branches or pull requests

4 participants