Skip to content
This repository has been archived by the owner on Oct 16, 2019. It is now read-only.

Links to Glitch starter project should open in new window #59

Closed
beaucarnes opened this issue May 18, 2018 · 2 comments
Closed

Links to Glitch starter project should open in new window #59

beaucarnes opened this issue May 18, 2018 · 2 comments

Comments

@beaucarnes
Copy link
Member

Some challenges link to a Glitch starter project. The link opens in the same window. It would be more user-freindly if the link opened in a new window/tab. Most people clicking on that link will want the fCC page to still be open so they can submit their project. This also applies to GitHub link.

Example url: https://deploy-preview-45--freecodecamp-learn.netlify.com/information-security-and-quality-assurance/advanced-node-and-express/use-a-template-engines-powers

Image of one page that has the link:

image

@nikrb
Copy link
Member

nikrb commented May 21, 2018

anchor tags need target="_blank".
Few dozen instances in half a dozen files:
./challenges/06-information-security-and-quality-assurance/quality-assurance-and-information-security-projects.json
./challenges/06-information-security-and-quality-assurance/advanced-express-tools.json
./challenges/06-information-security-and-quality-assurance/testing-with-chai.json
./challenges/06-information-security-and-quality-assurance/helmetjs.json
./challenges/05-apis-and-microservices/apis-and-microservices-projects.json
./challenges/08-coding-interview-prep/take-home-projects.json

and 2 more for github:
./challenges/03-front-end-libraries/react-and-redux.json
./challenges/04-data-visualization/data-visualization-projects.json

@tchaffee
Copy link

tchaffee commented Jul 9, 2018

@Bouncey can this be closed? This really belongs on the curriculum repo and the PR was already closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants