Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set defaults in the config #64

Closed
raisedadead opened this issue Nov 23, 2021 · 2 comments
Closed

Set defaults in the config #64

raisedadead opened this issue Nov 23, 2021 · 2 comments
Milestone

Comments

@raisedadead
Copy link
Member

Need to audit set sane defaults in https://github.com/freeCodeCamp/news/tree/main/config once we go full JAMStack.

@raisedadead raisedadead self-assigned this Nov 23, 2021
@raisedadead raisedadead added this to the JAMStack v1 milestone Dec 9, 2021
@raisedadead raisedadead removed their assignment Jan 3, 2022
@raisedadead
Copy link
Member Author

raisedadead commented Jan 3, 2022

@scissorsneedfoodtoo can you confirm that there are reasonable defaults in place to prevent failed builds?

@scissorsneedfoodtoo
Copy link
Contributor

@raisedadead, yes, I just did some tests and the defaults in the config file should be enough to prevent failed builds. Did some test builds and missing values (Algolia and AdSense keys, posts per page, etc.) won't result in failed builds.

Once the original author / translator feature is decoupled from the actual build process, the only strict requirements we'll have are LOCALE_FOR_UI and the correct keys from Ghost for that locale.

I think we can close this for now, and adjust the defaults later if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants