Cleanup integer conversion #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice, thanks for PR!
…On Wed, Aug 24, 2022 at 2:02 AM Henning Rogge ***@***.***> wrote:
Moved value conversion to golang math package constants, cleanup unsigned
integer handling, remove recovery() usage and add testcases to validate
that unsigned integer conversion and custom variants of int/uint can now be
converted automatically.
------------------------------
You can view, comment on, or merge this pull request online at:
#25
Commit Summary
- 6155ac3
<6155ac3>
use constants from math package to fix private constants for integer limits
- a048d82
<a048d82>
remove recovery() usage and cleanup uint handling
- 21196a3
<21196a3>
Add additional testcases for integer conversion
File Changes
(2 files <https://github.com/freeconf/yang/pull/25/files>)
- *M* val/conv.go
<https://github.com/freeconf/yang/pull/25/files#diff-be6bdc81a1b284d2983671b53d84f7cbd7d5622e4caec833209645c230a1367c>
(64)
- *M* val/conv_test.go
<https://github.com/freeconf/yang/pull/25/files#diff-aad536703bbb8b7b1b505ff2d7c6e62090beed6fdc5e52f5404caab11efddf10>
(24)
Patch Links:
- https://github.com/freeconf/yang/pull/25.patch
- https://github.com/freeconf/yang/pull/25.diff
—
Reply to this email directly, view it on GitHub
<#25>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACA7WFCUHDXSEK7X5U3N3V2W3GPANCNFSM57N6PPBA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved value conversion to golang math package constants, cleanup unsigned integer handling, remove recovery() usage and add testcases to validate that unsigned integer conversion and custom variants of int/uint can now be converted automatically.