Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing algorithm used for hash locks #233

Open
realcr opened this issue Jul 17, 2019 · 0 comments
Open

Changing algorithm used for hash locks #233

realcr opened this issue Jul 17, 2019 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@realcr
Copy link
Member

realcr commented Jul 17, 2019

Hash locks are being used in the protocol to allow atomicity of payments. Currently hash locks are implemented using SHA512/256.

It might be safer to use a different algorithm, for example bcrypt (As suggested in issue #196). On the other hand, it might degrade performance. I'm not yet sure what is the correct thing to do here.

The implementation can be found in components/crypto/src/hash_lock.rs
Note that changing the implementation might require changing the internal structure of HashedLock (For example, if we want to add hash salt).

@realcr realcr added question Further information is requested enhancement New feature or request labels Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant