Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Debian build script outputs incorrect log messages when using PKG_PATH option #426

Closed
zenmonkeykstop opened this issue Mar 14, 2023 · 0 comments · Fixed by #427
Closed

Comments

@zenmonkeykstop
Copy link
Contributor

The scripts/build-debianpackage script can be used in two ways:

  • if the PKG_PATH env var is set, it will attempt to build a debian package from either a source tree or a source tarball at the location in PKG_PATH, using the latest changelog entry to set the package version
  • if PKG_PATH is not set, but PKG_VERSION is set, it will attempt to checkout and verify a production-signed tag $PKG_VERSION and build the debian package from the tagged source.

In recent builds, it came to light that even if it was invoked with PKG_PATH, the script will still set PKG_VERSION using the latest tag and either fail if that tag is not production-signed, or just use PKG_VERSION erroneously in messages instead of the actual version as pulled from the changelog.

This causes confusion, and delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant