Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure scheduler runs for adding 1000 sources #1008

Open
sssoleileraaa opened this issue Mar 25, 2020 · 1 comment
Open

ensure scheduler runs for adding 1000 sources #1008

sssoleileraaa opened this issue Mar 25, 2020 · 1 comment

Comments

@sssoleileraaa
Copy link
Contributor

Description

Once #944 is merged, we will be using a scheduler to add source widgets to the client, only when no source widgets exist. There are couple reasons there may be source widgets already in the list when the client receives a large number of sources from the server in a sync:

  1. The client was running when the server database was updated to insert a large number of sources
  2. The client starts when there are already sources in the local database so the first run of the client adds source widgets for those sources, then the database syncs with the server database which has lets say 1000 sources and therefore the scheduler code from Retry fixing blocked UI on client start. #944 is not run.

Also we need to benchmark these changes to make sure that using the scheduler improves performance in these scenarios.

@redshiftzero redshiftzero added this to QA Period - 3/17-3/31 (Kanban Mode) in SecureDrop Team Board Mar 25, 2020
@eloquence eloquence moved this from Sprint #48 - 4/2-4/15 to Nominated for next sprint in SecureDrop Team Board Apr 2, 2020
@eloquence eloquence moved this from Nominated for next sprint to Sprint #48 - 4/2-4/15 in SecureDrop Team Board Apr 3, 2020
@eloquence eloquence moved this from Sprint #49 - 4/22-5/6 to Near Term - SD Workstation in SecureDrop Team Board Apr 22, 2020
@eloquence
Copy link
Member

Deferring to near-term backlog as it's not been a significant issue for pilot installs so far (from our discussion, it seems most likely to arise in scenarios when a very large sync occurs after a long break in previous usage). We'll revisit this in the next sprint (after the current 4/22-5/6 sprint), at the earliest.

@eloquence eloquence removed this from Near Term - SD Workstation in SecureDrop Team Board Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants