Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy/paste context menus are rendered incorrectly #1064

Closed
eloquence opened this issue Apr 23, 2020 · 0 comments · Fixed by #1065
Closed

Copy/paste context menus are rendered incorrectly #1064

eloquence opened this issue Apr 23, 2020 · 0 comments · Fixed by #1065
Labels
bug Something isn't working

Comments

@eloquence
Copy link
Member

eloquence commented Apr 23, 2020

#1063 introduced copy & paste (yay!). However, as originally observed here, the "Copy/Select All" context menu for journalist replies is rendered incorrectly:

I'm able to use the "Copy/select all" right-click menu just fine on source messages. When I attempt to use it on replies, it pops up, but it does not respond to the keyboard, the "Copy" menu is enabled (it's disabled for messages), and mousing over the menu options does not highlight the selected menu entry. The menu stays in the state illustrated by the screenshot.

The "Select all" action does work when you click it, but the "Copy" action does not until you select something, i.e. it is in fact disabled, even though it is rendered as enabled.

For some reason the menu also has extra padding on it for replies that it doesn't have for source messages.

Of lower severity, the selection color in the context menu for source messages (when you mouse over a menu option like "Select all") is white on grey, rendering options nearly invisible when you attempt to select them.

(All testing in master running in sd-app in Qubes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant