Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect reply associations in client database #1149

Closed
eloquence opened this issue Sep 24, 2020 · 2 comments · Fixed by #1162
Closed

Fix incorrect reply associations in client database #1149

eloquence opened this issue Sep 24, 2020 · 2 comments · Fixed by #1162
Assignees
@sssoleileraaa
Labels
bug Something isn't working release blocker
Projects
SecureDrop Team Board

Comments

@eloquence
Copy link
Member

As noted in #1148, we have a production issue where replies are wrongly associated with a UUID instead of an ID as the foreign key. This has not caused any issues yet since we do not currently display reply authorship, but will cause issues for pilot users the moment we introduce reply badges.

We should consider a DB migration or other strategy for ensuring that data in production databases is corrected, if possible.
@eloquence eloquence added the bug Something isn't working label Sep 24, 2020
@eloquence
Copy link
Member Author

(Since this is closely related to ongoing reply badges work, pulling into current sprint.)

@eloquence eloquence added this to SecureDrop Sprint #59 - 9/17-10/1 in SecureDrop Team Board Sep 24, 2020
@sssoleileraaa sssoleileraaa self-assigned this Sep 30, 2020
@sssoleileraaa sssoleileraaa mentioned this issue Oct 8, 2020
Closed
@eloquence eloquence moved this from SecureDrop Sprint #60 - 10/1-10/15 to Next sprint candidates in SecureDrop Team Board Oct 14, 2020
@eloquence
Copy link
Member Author

Marked as release blocker since we should be careful to release from main to production users until we have a migration in place for incorrect historical data.

@eloquence eloquence moved this from Next sprint candidates to SecureDrop Sprint #61 - 10/15-10/28 in SecureDrop Team Board Oct 15, 2020
@eloquence eloquence mentioned this issue Oct 16, 2020
Closed
36 tasks
@sssoleileraaa sssoleileraaa mentioned this issue Oct 21, 2020
Merged
2 tasks
SecureDrop Team Board automation moved this from SecureDrop Sprint #61 - 10/15-10/28 to Done Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sssoleileraaa sssoleileraaa

Labels
bug Something isn't working release blocker
Projects
No open projects
SecureDrop Team Board
Done
Milestone
No milestone
2 participants
@eloquence @sssoleileraaa