Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a CI job to make it easier to spot linter issues #1212

Closed
sssoleileraaa opened this issue Feb 2, 2021 · 0 comments 路 Fixed by #1262
Closed

Create a CI job to make it easier to spot linter issues #1212

sssoleileraaa opened this issue Feb 2, 2021 · 0 comments 路 Fixed by #1262
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sssoleileraaa
Copy link
Contributor

I looks like all the tests are passing in CI, but Black and Isort are not pleased:

Oh no! 馃挜 馃挃 馃挜
1 file would be reformatted, 80 files would be left unchanged.
make: *** [Makefile:15: check-black] Error 1
ERROR: /home/circleci/project/securedrop_client/gui/widgets.py Imports are incorrectly sorted.

Perhaps in the future it would make sense to have a separate CI target for linting, which would make detecting these issues much quicker. Happy to open a ticket if you agree.

Originally posted by @emkll in #1211 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CI job to make easier to spot linting issues gonzalo-bulnes/securedrop-client
2 participants
@eloquence @sssoleileraaa