Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files are opened twice #1217

Closed
eloquence opened this issue Feb 5, 2021 · 3 comments · Fixed by #1220
Closed

Files are opened twice #1217

eloquence opened this issue Feb 5, 2021 · 3 comments · Fixed by #1220
Labels
bug Something isn't working release blocker

Comments

@eloquence
Copy link
Member

Tested in 0.4.0-dev-20210204-154420 on Qubes

STR

Download and open a file in the SecureDrop Client

Expected behavior

A single disposable VM is opened to view the file

Actual behavior

Two disposable VMs are opened to view the file (two lines are added to the log)
@eloquence eloquence added the bug Something isn't working label Feb 5, 2021
@eloquence
Copy link
Member Author

Introduced in 649cc95 / #1206. Now seeing if I can narrow it down.

@eloquence
Copy link
Member Author

The root cause appears to be

securedrop-client/securedrop_client/gui/widgets.py

Line 2298 in 649cc95

self.installEventFilter(self)
(added in that commit) which causes the event handler to fire twice.

@emkll emkll added this to Near Term - SD Workstation in SecureDrop Team Board Feb 8, 2021
@eloquence eloquence moved this from Near Term - SD Workstation to Next sprint candidates in SecureDrop Team Board Feb 17, 2021
@eloquence
Copy link
Member Author

I'll poke a bit more at this and will make a smol PR.

@eloquence eloquence moved this from Next sprint candidates to SecureDrop Sprint #67 - 2/18-3/3 in SecureDrop Team Board Feb 18, 2021
@eloquence eloquence moved this from SecureDrop Sprint #67 - 2/18-3/3 to In Development in SecureDrop Team Board Feb 19, 2021
@eloquence eloquence mentioned this issue Feb 19, 2021
Merged
5 tasks
@eloquence eloquence removed this from In Development in SecureDrop Team Board Feb 19, 2021
@eloquence eloquence mentioned this issue Feb 19, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working release blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent event handler from being triggered twice freedomofpress/securedrop-client
1 participant
@eloquence