Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeout for file download too large #546

Closed
sssoleileraaa opened this issue Aug 31, 2019 · 0 comments · Fixed by #567
Closed

timeout for file download too large #546

sssoleileraaa opened this issue Aug 31, 2019 · 0 comments · Fixed by #567
Labels
bug Something isn't working
Milestone

Comments

@sssoleileraaa
Copy link
Contributor

Description

When testing the client in Qubes, quite often a file fails to download when I click the download link with the following error log message: BaseError: timeout is too large

I think the problem is that larger files are timing out too soon. This will be less of a problem when we add Range requests and allow segmented downloading, but for now we should probably adjust our default timeout value for file downloads. Or try increasing the timeout value each time the api call is retried.

Also, this shouldn't be causing a BaseError. This should cause a RequestTimeoutError which will pause the queue. This should be a fast fix to the DownloadFileJob, so if the incrementing timeouts during retries takes too long, might make sense to split this out into a new issue.

STR

  1. Attach several files to a message, try files of different sizes (larger files are more likely to cause the timeout error)
  2. Start by downloading the smallest file first and work your way up to the larger files until you see it fail. Check the logs for the error mentioned above.
@sssoleileraaa sssoleileraaa added the bug Something isn't working label Aug 31, 2019
@eloquence eloquence added this to Nominated for next sprint in SecureDrop Team Board Sep 19, 2019
@eloquence eloquence moved this from Nominated for next sprint to Near Term Backlog in SecureDrop Team Board Sep 19, 2019
@redshiftzero redshiftzero moved this from Near Term Backlog to Nominated for next sprint in SecureDrop Team Board Sep 19, 2019
@eloquence eloquence moved this from Nominated for next sprint to Near Term Backlog in SecureDrop Team Board Sep 19, 2019
@eloquence eloquence moved this from Near Term - SD Workstation to Nominated for Next Sprint in SecureDrop Team Board Oct 8, 2019
@eloquence eloquence added this to the 0.2.0alpha milestone Oct 8, 2019
@eloquence eloquence moved this from Nominated for Next Sprint to Current Sprint - 10/9-10/23 in SecureDrop Team Board Oct 9, 2019
@sssoleileraaa sssoleileraaa moved this from Current Sprint - 10/9-10/23 to In Development in SecureDrop Team Board Oct 10, 2019
@sssoleileraaa sssoleileraaa moved this from In Development to Ready for Review in SecureDrop Team Board Oct 16, 2019
@eloquence eloquence removed this from Ready for Review in SecureDrop Team Board Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants