Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide/Show Password on Login Screen #659

Closed
ninavizz opened this issue Dec 11, 2019 · 3 comments · Fixed by #679
Closed

Hide/Show Password on Login Screen #659

ninavizz opened this issue Dec 11, 2019 · 3 comments · Fixed by #679
Assignees

Comments

@ninavizz
Copy link
Member

Picking-up on Issue #446...

Problem

I cannot see what I am typing-in, when I type my 5-word long passphrase into the SecureDrop client. That super sucks. While the same can be said for the first dialogs on booting the machine, separate tickets are being filed with those teams (once given the green light to, of course) to request the same from them.

Solution

One of two paths. The easiest, would be to make "Show" the one view option for passphrases on the Client. I suspect there's legit over-the-shoulder concerns for that, however—but for the Pilot, I feel we can more reasonably beat it over user heads "DO NOT use this in a cafe or other public place w/ over-the-shoulder or camera options."

The second option, of course, is to fully implement the hide/show pattern implied in the mockups. Icons for the hide/show control, are in the Content Inventory (in this repo's wiki's styleguide, and also in the Content Design ticket in the ux-repo).

@eloquence
Copy link
Member

Note that we will likely soon want a similar widget on the export drive passphrase dialog.

@kushaldas kushaldas self-assigned this Dec 20, 2019
@ninavizz
Copy link
Member Author

@kushaldas! I added you to the Zeplin project for this, but it shows you have yet to accept that invitation. The icon asset is in the securedrop-ux repo; all icons for the Workstation are tracked within this issue, which is pinned to the top of the ux repo's issues page. Let me know if you have any troubles, and enjoy your time over the US holidaze with family!

@ninavizz
Copy link
Member Author

Oops—on second thought Kushal, I just noticed I have an out-dated icon in that inventory. I'll update it tomorrow (Monday) my time, with the correct art. I have a lot of clean-up to do on that table, evidently!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants