Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync removes focus from replybox #726

Closed
sssoleileraaa opened this issue Jan 22, 2020 · 2 comments · Fixed by #740
Closed

Sync removes focus from replybox #726

sssoleileraaa opened this issue Jan 22, 2020 · 2 comments · Fixed by #740
Labels
bug Something isn't working release blocker

Comments

@sssoleileraaa
Copy link
Contributor

STR

  1. click in the reply box (you can type something or not)
  2. wait until bg sync (increase frequency in the client to make this waiting period less painful or get a cup of coffee)

Expected

For the cursor to remain in the replybox

Actual

The replybox is no longer selected. If you were typing your have to click back into the replybox to continue typing.

@eloquence
Copy link
Member

I was able to reproduce this easily. I only had to wait a few seconds, I think because there may have been multiple MetadataSync jobs in the queue from previous actions, and it just kept stealing the focus repeatedly.

@eloquence eloquence changed the title a sync removes cursor from replybox Sync removes focus from replybox Jan 23, 2020
@eloquence eloquence added this to Current Sprint (1/22-2/5) in SecureDrop Team Board Jan 23, 2020
@ntoll
Copy link
Contributor

ntoll commented Jan 27, 2020

This took a little unpicking to find a simple solution. You can see WiP on my sync-docus-replybox (typo for focus). Just need to add tests for coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release blocker
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants