Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling export in progress conflicts with subsequent export attempts #992

Closed
eloquence opened this issue Mar 24, 2020 · 4 comments · Fixed by #1011
Closed

Cancelling export in progress conflicts with subsequent export attempts #992

eloquence opened this issue Mar 24, 2020 · 4 comments · Fixed by #1011
Assignees
Labels
bug Something isn't working release blocker

Comments

@eloquence
Copy link
Member

eloquence commented Mar 24, 2020

Steps to reproduce (tested in Qubes on master):

  1. Export a file in the client
  2. While export is running, cancel.
  3. Immediately export again

Expected behavior

Export is aborted, new export completes successfully

Actual behavior

Things get a bit wacky:

  • it starts with the "Preparing to export" screen spinning for a while
  • then we briefly see the "Export successful" message flash from the previous export
  • then we see "Ready to export", but instead of "Continue", the primary button says "Done", and the dialog message is still the "Remember to be careful" message.
@eloquence eloquence added the bug Something isn't working label Mar 24, 2020
@eloquence
Copy link
Member Author

eloquence commented Mar 24, 2020

Unlike the initial screen, once you submit a password, it should IMO just disable the "Cancel" button until the operation either succeeds or fails.

@eloquence
Copy link
Member Author

eloquence commented Mar 25, 2020

This screenshot illustrates the final "mutant dialog" state -- note the "Ready to export" with the "Done" button and the message from the success screen. Clicking "Done" actually takes you to the passphrase entry screen.

Screenshot_2020-03-24_19-56-03

@ninavizz
Copy link
Member

Yes, in the original design users were supposed to get a "Do you really wanna do this?" dialog if they tried to cancel after authenticating—and it was agreed that canceling after that stage would introduce too many complications to execute this correctly, for Beta.

@redshiftzero redshiftzero added this to the 0.2.xbeta milestone Mar 25, 2020
@redshiftzero redshiftzero added this to QA Period - 3/17-3/31 (Kanban Mode) in SecureDrop Team Board Mar 25, 2020
@eloquence
Copy link
Member Author

(Tracked as release blocker to reflect severity, we can demote to known issue if we run out of time.)

@rmol rmol self-assigned this Mar 25, 2020
SecureDrop Team Board automation moved this from QA Period - 3/17-3/31 (Kanban Mode) to Done Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release blocker
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants