Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use queue for source deletion #674

Merged
merged 1 commit into from Dec 19, 2019
Merged

Use queue for source deletion #674

merged 1 commit into from Dec 19, 2019

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Dec 18, 2019

Description

Add api_jobs/sources.py containing DeleteSourceJob, add its priority to queue.JOB_PRIORITIES, and use it in logic.delete_source. Add tests.

Fixes #402.

Test Plan

  • Run make dev in your securedrop working copy
  • Check out this branch in your securedrop-client working copy
  • Run the client with run.sh
  • Delete a source.

Checklist

  • I have tested these changes in the appropriate Qubes environment

@rmol
Use queue for source deletion
b463830 
Add api_jobs/sources.py containing DeleteSourceJob, add its priority
to queue.JOB_PRIORITIES, and use it in logic.delete_source. Add tests.
@rmol
Copy link
Contributor Author

rmol commented Dec 18, 2019

Should we think about folding the starring jobs into api_jobs/sources.py?

sssoleileraaa
sssoleileraaa approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Let's discuss how we can reorganize python files and classes for api_jobs and other queue jobs outside of this PR.

@sssoleileraaa sssoleileraaa merged commit f391abe into master Dec 19, 2019
@sssoleileraaa sssoleileraaa deleted the 402-queue-source-delete branch December 19, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sssoleileraaa sssoleileraaa sssoleileraaa approved these changes

@kushaldas kushaldas Awaiting requested review from kushaldas kushaldas is a code owner

@redshiftzero redshiftzero Awaiting requested review from redshiftzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete sources using general queue
2 participants
@rmol @sssoleileraaa