Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds initial packaging for securedrop-log #104

Merged
merged 3 commits into from Dec 11, 2019
Merged

Adds initial packaging for securedrop-log #104

merged 3 commits into from Dec 11, 2019

Conversation

kushaldas
Copy link
Contributor

Adds Buster package for the securedrop-log package.

How to test?

  • In the securedrop-log directory, run python3 setup.py sdist
  • PKG_VERSION=0.0.1 PKG_PATH=/home/user/project/securedrop-log/dist/securedrop-log-0.0.1.tar.gz make securedrop-log Remember to change the path based on your actual code path.

@redshiftzero redshiftzero self-requested a review December 6, 2019 15:43
@redshiftzero redshiftzero added this to Under Review in SecureDrop Team Board Dec 6, 2019
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! a couple of comments inline

securedrop-log/debian/control Outdated Show resolved Hide resolved
securedrop-log/debian/securedrop-log.install Outdated Show resolved Hide resolved
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two commits, adding a CI job to test and a small fix, otherwise this looks good to me

@kushaldas I'm going to let you review my changes and merge

@kushaldas
Copy link
Contributor Author

@redshiftzero Those two new commits look good to me. Approved.

@redshiftzero redshiftzero merged commit b2c7e2e into master Dec 11, 2019
SecureDrop Team Board automation moved this from Under Review to Done Dec 11, 2019
@redshiftzero redshiftzero deleted the package_log branch December 11, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants