Builds nightly debs for sd-svs-disp package #131
Conversation
|
N.B. conflicts with #130 |
| @@ -276,6 +276,8 @@ jobs: | |||
| - *setsvsdispname | |||
| - *setmetapackageversion | |||
| - *builddebianpackage | |||
| - *addsshkeys | |||
| - *commitworkstationdebs | |||
There was a problem hiding this comment.
heads up this job runs per-PR
per package generally we have two CI jobs, one running per-PR that builds the latest released version (see: build-buster-securedrop-export), and one running nightly (see: build-nightly-buster-securedrop-export) that bumps the version and after build commits the package
for this change we should add a new nightly job and leave this build-buster-securedrop-workstation-svs-disp as is
There was a problem hiding this comment.
addressed, good call
conorsch
force-pushed
the
build-nightly-packages-for-sd-svs-disp
branch
from
f8c8815
to
62e3358
Compare
conorsch
changed the title
conorsch
force-pushed
the
build-nightly-packages-for-sd-svs-disp
branch
from
62e3358
to
18f89ea
Compare
|
New build is already live via freedomofpress/securedrop-apt-test@43dd60f, due to a mistake in an earlier version of this PR (see comment by @redshiftzero). Ready for review. |
.circleci/config.yml
Outdated
| - checkout | ||
| - *installdeps | ||
| - *setsvsdispname | ||
| - *setmetapackageversion |
There was a problem hiding this comment.
does this bump the version? i think with this it will just keep committing versions of the same package
There was a problem hiding this comment.
Agreed. At a glance, we don't have sufficient logic to increment here, we'll need to write something new. Neither &getlatestreleasedversion nor &getnightlyversion are what we want, because both assume the package has a tag that matches its version, which isn't true since this package is managed inside this repo.
.circleci/config.yml
Outdated
| @@ -320,3 +332,4 @@ workflows: | |||
| - build-nightly-buster-securedrop-log: | |||
| requires: | |||
| - build-nightly-buster-securedrop-export | |||
| - build-nightly-buster-securedrop-workstation-svs-disp | |||
There was a problem hiding this comment.
let's have this require build-nightly-buster-securedrop-log (this is so the jobs don't race each other, see comment above the nightly key)
this will conflict with #129 but we can rebase whichever gets merged last
|
Appended d6837be to this branch to bump metapackage version and update changelog for sd-svs-disp nightly builds, which should address the outstanding review comment in #131 (comment) |
We were already building the package on PR runs, but not as nightlies. Adds a nightly job to changes propagate to the dev lfs repo. Identified in freedomofpress/securedrop-workstation#282 (comment)
Avoid races, don't build in parallel.
emkll
force-pushed
the
build-nightly-packages-for-sd-svs-disp
branch
from
d6837be
to
53f402d
Compare
|
Rebased on latest master (due to the merge of #129) see https://circleci.com/gh/freedomofpress/securedrop-debian-packaging/2449 for test results |
We were already building the package on PR runs, but not as nightlies.
Adds a nightly job to changes propagate to the dev lfs repo.
Identified in freedomofpress/securedrop-workstation#282 (comment)