securedrop-workstation-config package Makefile and CI #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
suggested changes
Feb 11, 2020
There was a problem hiding this comment.
Changelog needs a bit of attention. As for whether the package is useful, we're not currently using it for much—but having the foothold within the VMs, to feed in additional packages via unattended-upgrades (without Salt logic) seems quite valuable, so let's preserve it for now, and re-evaluate removal post-pilot.
emkll
force-pushed
the
workstation-config-ci
branch
from
dcba673
to
f1906ee
Compare
Builds the metapackage used for template builds
This package is only used for the Template build process, and for now only used to pull in dependencies. Arguably could be simplified by explicitly installing as part of the template install script, but could be helpful in the future. Omitting nightlies of this package for simplicity, we should revisit if we make broader changes to this package.
This version update is due to build/ci changes
emkll
force-pushed
the
workstation-config-ci
branch
from
f1906ee
to
7043f05
Compare
|
thanks @conorsch. Comments have been addressed, rebased on latest |
conorsch
approved these changes
Feb 11, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards freedomofpress/securedrop-workstation#424
Ensures securedrop-workstation-config can build in CI, and provide Makefile target
Test plan