Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes libreoffice grsec error #47

Closed
wants to merge 1 commit into from
Closed

Fixes libreoffice grsec error #47

wants to merge 1 commit into from

Conversation

kushaldas
Copy link
Contributor

@kushaldas kushaldas commented Jun 4, 2019

@kushaldas kushaldas requested a review from emkll June 4, 2019 16:31
@eloquence eloquence added this to Ready for review in SecureDrop Team Board Jun 4, 2019
@emkll
Copy link
Contributor

emkll commented Jun 7, 2019

Thanks @kushaldas !
In the initial review of freedomofpress/securedrop-workstation#263, I had mis attributed the error I've observed to a missing pax flag, when in fact the issue pas the paxctld service was not running. Based on further review of that pr, which did not use the updated verison of this package, and the comments in the paxctld.conf file, this pax flag is not strictly necessary. While we can still observe a line in the logs, LibreOffice (writer, calc, etc..) works fine.
I propose we close this PR and not merge at this time, we can re-open in the future if this poses further issues (if we do re-open, we should also bump the version/changelog of the package).

@emkll emkll closed this Jun 7, 2019
@emkll emkll moved this from Ready for review to Done in SecureDrop Team Board Jun 7, 2019
@eloquence eloquence removed this from Done in SecureDrop Team Board Jun 7, 2019
@sssoleileraaa sssoleileraaa deleted the update_paxctl branch September 13, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants