Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the script to add multiple wheel hashes #85

Merged
merged 1 commit into from Nov 7, 2019

Conversation

kushaldas
Copy link
Contributor

@kushaldas kushaldas commented Nov 4, 2019

Now we can have multiple wheels hashes into the build-requirement
script, for python3.5 and python3.7

How to test?

On a Buster VM/system

  • PKG_DIR=/home/user/code/securedrop-client make requirements
  • PKG_DIR=/home/user/code/securedrop-client make requirements

This should create a build-requirements.txt with multiple hashes for sqlalchemy and MarkupSafe wheels.

Now we can have multiple wheels hashes into the build-requirement
script, for python3.5 and python3.7
@eloquence eloquence added this to Ready for Review in SecureDrop Team Board Nov 4, 2019
@redshiftzero redshiftzero moved this from Ready for Review to Under Review in SecureDrop Team Board Nov 5, 2019
@redshiftzero
Copy link
Contributor

this should be reviewed after #86, correct? (since the sha256sums.txt on this branch only has one wheel per dependency)

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! note the two checkboxes in the test plan are the same? just want to check I'm not missing something

after #87 is merged we can add tests when we make changes like this

@redshiftzero redshiftzero merged commit 9050973 into master Nov 7, 2019
SecureDrop Team Board automation moved this from Under Review to Done Nov 7, 2019
@redshiftzero redshiftzero deleted the multiple_wheels branch November 7, 2019 14:05
@redshiftzero
Copy link
Contributor

Due to the make requirements checks that we have in CI (that ensure that the build requirements are up to date given what is in requirements.txt), when we changed make requirements to produce different build requirements - i.e. since build-requirements.txt should have wheels for both 3.5 and 3.7 - we also need to update the build-requirements.txt in repos with this check or CI build jobs will fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants