Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds wheels for client and proxy in Python3.7 #86

Merged
merged 1 commit into from Nov 6, 2019
Merged

Adds wheels for client and proxy in Python3.7 #86

merged 1 commit into from Nov 6, 2019

Conversation

kushaldas
Copy link
Contributor

This PR has the updated wheels build for Pytho3.7 for the securedrop-client project.

The sha256sums.txt file has been signed with my key.

@eloquence eloquence added this to Ready for Review in SecureDrop Team Board Nov 4, 2019
@redshiftzero
Copy link
Contributor

This is towards #82

@redshiftzero redshiftzero mentioned this pull request Nov 4, 2019
Closed
redshiftzero
redshiftzero suggested changes Nov 4, 2019
View reviewed changes
simple/markupsafe/index.html Outdated
@@ -11,5 +11,6 @@ <h1>Links for markupsafe</h1>
<a href="/localwheels/MarkupSafe-1.0-cp35-cp35m-linux_x86_64.whl">MarkupSafe-1.0-cp35-cp35m-linux_x86_64.whl</a><br/>
<a href="/localwheels/MarkupSafe-1.1.0.tar.gz">MarkupSafe-1.1.0.tar.gz</a><br/>
<a href="/localwheels/MarkupSafe-1.1.0-cp35-cp35m-linux_x86_64.whl">MarkupSafe-1.0-cp35-cp35m-linux_x86_64.whl</a><br/>
<a href="/localwheels/MarkupSafe-1.1.0-cp37-cp37m-linux_x86_64.whl">MarkupSafe-1.0-cp37-cp37m-linux_x86_64.whl</a><br/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version here in the href is 1.1.0, wheel has version 1.0 - is this a bug in one of our scripts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, it was typo from an year ago.

sha256sums.txt
@@ -13,6 +13,7 @@ fdcaedc1fb19a63d7d875b0105b0a5b496dd0989330d454a42bcb401fa5454ec furl-2.0.0.tar
87ee3f74ba3ea544e683a5a22e7e34f4d1cf3ad34414b5f3858becf00facf1d6 Mako-1.0.7-py3-none-any.whl
4e02fde57bd4abb5ec400181e4c314f56ac3e49ba4fb8b0d50bba18cb27d25ae Mako-1.0.7.tar.gz
6a7078a2fb4406458d6ae3579e4eb01a9bdc0a9a0686a28fa50c19a039e3fcb8 MarkupSafe-1.0-cp35-cp35m-linux_x86_64.whl
3c9bf8fb4c3cf7dd11fd465132156d4c3cddb926d39bdbd0f0bf5920fd8009a4 MarkupSafe-1.0-cp37-cp37m-linux_x86_64.whl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: add the linux_x86_64 Python 3.7 wheel for PyYAML also? (optional because this PR does specifically say "for the client" so we can do in two PRs if you prefer. since we also need to update wheels for buster for e.g. the proxy adding that one wheel would be nice because then we are good to go with respect to buster and our pip mirror), see #82

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, and the PR updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kewl thanks!

@redshiftzero redshiftzero moved this from Ready for Review to Under Review in SecureDrop Team Board Nov 4, 2019
@redshiftzero redshiftzero mentioned this pull request Nov 5, 2019
Merged
2 tasks
@redshiftzero redshiftzero moved this from Under Review to In Development in SecureDrop Team Board Nov 5, 2019
@kushaldas kushaldas changed the title Adds wheels for client in Python3.7 Adds wheels for client and proxy in Python3.7 Nov 6, 2019
redshiftzero
redshiftzero reviewed Nov 6, 2019
View reviewed changes
simple/markupsafe/index.html
@@ -9,7 +9,5 @@ <h1>Links for markupsafe</h1>
<!-- <a href="">FILENAME</a><br/> -->
<a href="/localwheels/MarkupSafe-1.0.tar.gz">MarkupSafe-1.0.tar.gz</a><br/>
<a href="/localwheels/MarkupSafe-1.0-cp35-cp35m-linux_x86_64.whl">MarkupSafe-1.0-cp35-cp35m-linux_x86_64.whl</a><br/>
<a href="/localwheels/MarkupSafe-1.1.0.tar.gz">MarkupSafe-1.1.0.tar.gz</a><br/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a link to MarkupSafe-1.0-cp37-cp37m-linux_x86_64.whl here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, typo again, sorry. Updated the PR.

redshiftzero
redshiftzero approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! my comments are addressed and hashes are consistent with what is on our pip mirror and the sig verifies

@redshiftzero redshiftzero merged commit 12a0111 into master Nov 6, 2019
SecureDrop Team Board automation moved this from In Development to Done Nov 6, 2019
@redshiftzero redshiftzero deleted the wheels_for_client_buster branch November 6, 2019 17:11
@eloquence eloquence mentioned this pull request Nov 6, 2019
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redshiftzero redshiftzero redshiftzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
SecureDrop Team Board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kushaldas @redshiftzero