Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds securedrop-workstation-config 0.1.2 package #34

Merged
merged 3 commits into from Feb 12, 2020

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Feb 11, 2020

Towards freedomofpress/securedrop-workstation#424

Status

Ready for review

Description of changes

Bumps the version for release, should be a no-op. packaging changes and logs:

Test plan

  • Removing packages should not cause any server side lfs issues
  • Checkout securedrop-debian-packaging
  • PKG_VERSION=0.1.2 make securedrop-workstation-config
  • sha256 sum of the built package is identical to the one committed here.

Checklist

@emkll emkll requested a review from conorsch February 11, 2020 22:22
@emkll emkll added this to Ready for Review in SecureDrop Team Board Feb 11, 2020
@conorsch
Copy link
Contributor

Good call on the old package cleanup, we've been meaning to do that for a while. The commit you pushed purging all buster packages from 2019 shaves ~356MB off the repo, which is grand. Also removing the stretch packages from 2019 would remove another ~876MB, so I'm going to push up a commit doing so.

The previous cleanup commit removed all 2019 packages from
workstation/buster/, here we also remove from workstation/stretch/.

In case it's useful to future maintainers:

  find workstation/stretch | grep -i dev-2019 | xargs -r du -ch | tail -n1
  find workstation/stretch | grep -i dev-2019 | xargs -r git rm
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, thanks for the super clear test plan. Pushed up one additional commit to cull more packages—for reference:

$ find -type f -iname '*.deb' | wc -l
307
$ find -type f -iname '*.deb' | xargs du -ch | tail -n1
1.4G	total
$ git checkout master
Checking out files: 100% (340/340), done.   
Switched to branch 'master'
$ find -type f -iname '*.deb' | wc -l
645
 $ find -type f -iname '*.deb' | xargs du -ch | tail -n1
2.6G	total

More than 1GB reduction for the repo, which is great. Finally, regarding:

Removing packages should not cause any server side lfs issues

It's worth reiterating that reprepro, for better or for worse, only serves the most recent version of any given package—so even though the old debs were visible in the web docroot, they were not accessible to apt clients.

@conorsch conorsch merged commit 776e1be into master Feb 12, 2020
SecureDrop Team Board automation moved this from Ready for Review to Done Feb 12, 2020
@conorsch conorsch deleted the securedrop-config-0.1.2 branch July 9, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants