Add Tor 0.4.3.6 packages #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssoleileraaa
previously approved these changes
Jul 14, 2020
sssoleileraaa
dismissed
their stale review
mistake in review when comparing checksum between torproject and here for the geo package
|
Okay now looks good with the updated test plan. Thanks @rmol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of changes
Adds Tor 0.4.3.6 packages.
Testing
Confirm checksums for https://deb.torproject.org/torproject.org/pool/main/t/tor/tor_0.4.3.6-1~xenial+1_amd64.deb and https://deb.torproject.org/torproject.org/pool/main/t/tor/tor-geoipdb_0.4.3.6-1~xenial+1_all.deb match the checksums for the packages in this PR.
Also, run
make fetch-tor-packagesfrom the freedomofpress/securedrop#5374 PR branch (this usesapt's automatic package verification logic) and confirm checksums of the files downloaded to the build directory match the checksums for the packages included in this PR.